feat(code-action): add string literal syntax conversion#775
Merged
Conversation
…rsion - Introduce code action to convert between double-quoted and indented string literals in Nix code - Handle escaping rules and interpolation preservation for both formats - Offer action only when cursor is on a string literal node - Add comprehensive tests for empty strings, escapes, quotes, tabs, newlines, and interpolations - Update build configuration to include new implementation files
…on-10 # Conflicts: # nixd/lib/Controller/CodeAction.cpp
- Add check to bypass rewriting when string is used as an attribute name - Prevents duplicate handling already covered by attribute name actions
inclyc
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add code action to convert between double-quoted strings (
"...") and indented strings (''...'').Example Transformation:
"hello\nworld"''hello↵world''''hello ${name}''"hello ${name}"Changes
nixd/lib/Controller/CodeActions/RewriteString.hnixd/lib/Controller/CodeActions/RewriteString.cppnixd/lib/Controller/CodeAction.cppnixd/lib/meson.buildBehavior
Action offered when:
Action NOT offered when:
Handles:
\n,\t,\\,\",\${↔ literal characters)"in content →\"when converting to double-quoted)${...}maintained in both formats)Test Plan
to-indented.md/to-dquote.md: Basic conversionempty-string.md: Empty string handlingescape-*.md: Escape sequences (newline, tab, backslash, quotes)interpolation.md/to-dquote-interpolation.md: Interpolation preservationnot-string.md: Negative test - action not offered on non-stringRelated