refactor(code-action): reorganize code actions into dedicated files and test subdirectories#765
Merged
Merged
Conversation
…ed files
Extract code action implementations from CodeAction.cpp into a dedicated
CodeActions/ subdirectory with separate files for each action type:
- AttrName.{h,cpp}: Quote/unquote attribute name actions
- FlattenAttrs.{h,cpp}: Flatten nested attribute set action
- JsonToNix.{h,cpp}: JSON to Nix conversion action
- NoogleDoc.{h,cpp}: Noogle documentation link action
- PackAttrs.{h,cpp}: Pack dotted paths to nested set actions
- Utils.{h,cpp}: Shared utilities (identifier validation, escaping, etc.)
This improves maintainability as the number of code actions grows,
following the suggestion from PR #764 review.
Move 63 test files from flat structure into category subdirectories to improve discoverability and match the source code organization: - attr-name/: Quote/unquote attribute name tests (14 files) - flatten-attrs/: Flatten nested attribute set tests (7 files) - json-to-nix/: JSON to Nix conversion tests (13 files) - noogle-doc/: Noogle documentation link tests (4 files) - pack-attrs/: Pack dotted paths tests (24 files) - quick-fix/: Quick fix diagnostic tests (1 file) This addresses the test directory organization suggested in PR #764 review.
takeokunn
force-pushed
the
feature/refactor-code-action
branch
from
bb39adb to
078ba02
Compare
inclyc
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the file structure suggestion from PR #764 review.
Commits
refactor(code-action): extract code action implementations to dedicated files c68c266
CodeAction.cppintoController/CodeActions/subdirectorytest(code-action): reorganize test files into category subdirectories 078ba02
Motivation
The growing number of code actions warrants a dedicated subdirectory structure for better maintainability.
Testing