fix(types): emit auto-import paths as files, not directories#4334
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
pi0
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
remake of #4333 for v2
❓ Type of change
📚 Description
duplicate description for posterity:
writeTypesemitsconst foo: typeof import('<path>').fooper auto-imported bindingfor some packages, the path ends up being the package directory rather than a file; this works fine for TypeScript with
moduleResolution: bundler, but Deno's TS host doesn't apply Node directory resolution to relative specifiers and bailsthis PR treats
./the same as an empty subpath & falls back to resolvedPath, which ends up having its extension strippedboth typescript + deno should resolve this equally well.
note: packages with different
exports.typesvsexports.imports(eg #2384) won't work correctly, either before or after this fix (but the error slightly changes 😆)📝 Checklist