Skip to content

fix: remove unused native bcrypt package (issue #40)#2588

Open
tmdeveloper007 wants to merge 1 commit into
nisshchayarathi:mainfrom
tmdeveloper007:fix-40-remove-bcrypt
Open

fix: remove unused native bcrypt package (issue #40)#2588
tmdeveloper007 wants to merge 1 commit into
nisshchayarathi:mainfrom
tmdeveloper007:fix-40-remove-bcrypt

Conversation

@tmdeveloper007

@tmdeveloper007 tmdeveloper007 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the unused bcrypt native C++ package from package.json dependencies. The project exclusively uses bcryptjs throughout the codebase.

Issue

Fixes #40: Fix duplicate bcrypt dependencies (bcrypt + bcryptjs)

Changes

  • Removed "bcrypt": "^6.0.0" from dependencies in package.json
  • All existing imports use bcryptjs (no import changes required)

Testing

  • npm run typecheck passes
  • No imports reference the native bcrypt package

Files Changed

  • package.json

Summary by CodeRabbit

  • Chores
    • Updated the project’s password-hashing dependency to a different compatible package.

@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Nisshchaya's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the gssoc:spam GSSoC: Spam contribution label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

⚠️ GSSoC Quality Check Failed — PR #2588

Hi @tmdeveloper007! 👋 Your PR has been flagged by our automated GSSoC quality check.

Issues found:

  • 📏 Trivially small change — Only 1 line(s) changed in 1 file. Changes this small are almost never meaningful contributions. Make sure your PR solves a real issue.

✅ How to fix this

  1. Read the issues listed above carefully
  2. Edit your PR title and description to address them
  3. Make sure your PR is linked to an open issue using closes #<issue-number>
  4. Make sure your changes are meaningful and solve a real problem

Once you've fixed these, a maintainer will review and remove the flag. If you believe this is a mistake, please comment below. 🙏

GSSoC'26 automation · Maintainer: @nisshchayarathi

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 252c2224-ee3d-4687-8a0a-cdbce83aab1e

📥 Commits

Reviewing files that changed from the base of the PR and between 07ceab7 and d7d714f.

📒 Files selected for processing (1)
  • package.json
💤 Files with no reviewable changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The change updates package.json to remove the bcrypt dependency and add bcryptjs, consolidating password hashing to a single library.

Changes

Dependency migration

Layer / File(s) Summary
Swap bcrypt for bcryptjs
package.json
Removed bcrypt and added bcryptjs in the dependencies list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: gssoc:approved, level:beginner

Poem

One less bcrypt, one more bcryptjs hop,
A tidy dependency list, no need to stop.
This bunny hashes passwords safe and neat,
With just one library, the build's complete! 🐇
Hop, hop, hooray for cleaner code today!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: removing unused native bcrypt in favor of bcryptjs for issue #40.
Linked Issues check ✅ Passed The PR leaves only bcryptjs in dependencies and aligns with the issue’s requirement to use one bcrypt library.
Out of Scope Changes check ✅ Passed No unrelated code changes are indicated beyond the bcrypt dependency cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tmdeveloper007

Copy link
Copy Markdown
Contributor Author

CodeRabbit review is passing. The Vercel deployment check requires authorization from the repository maintainer (@nisshchayarathi) — please visit your Vercel project settings and authorize the GitVerse GitHub App to enable deployments for this fork. Happy to help if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:spam GSSoC: Spam contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix duplicate bcrypt dependencies (bcrypt + bcryptjs)

1 participant