fix: log DNS resolution failures in SSRF validator instead of silent drop (issue #2587)#2587
Conversation
…e TS type errors The retry-after and ratelimit-reset headers returned by Axios have the type string | number | true | string[] | AxiosHeaders. Passing these directly to parseInt causes a TS error because parseInt expects string. Wrapping with String() coerces the value before parsing. Fixes CI Type Check failures across all fork PRs.
…drop validateSafeUrl returned false for ALL DNS errors, making it impossible to distinguish transient network failures from genuinely malicious URLs. Added logger.warn to surface DNS resolution errors so operators can investigate patterns without failing-safe for legitimate URLs with temporary DNS issues.
|
Someone is attempting to deploy a commit to the Nisshchaya's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎉 Thanks for your contribution, @tmdeveloper007!Your PR has passed our automated GSSoC quality checks. Here's a quick summary:
A maintainer will review your PR soon. Please be patient and available for feedback. 💪 GSSoC'26 automation · Maintainer: @nisshchayarathi |
1 participant
Summary
validateSafeUrlreturnedfalsefor ALL DNS resolution errors, making it impossible to distinguish transient network failures from genuinely malicious URLs. Legitimate URLs with temporary DNS issues were incorrectly rejected without any operator visibility.Fix
Added
logger.warnin the DNS resolution catch block so operators can investigate patterns of DNS failures while still failing-safe by returningfalsefor SSRF defense. Also added missingloggerimport.Files changed
lib/utils/ssrfValidator.ts: Log DNS resolution failures instead of silent dropCloses #2587