Hpc bugfixes#2
Open
Alireza-Khatami wants to merge 2 commits into
Open
Conversation
- cmake/DownloadProject.cmake: forward CMAKE_POLICY_VERSION_MINIMUM=3.5 to subprocess cmake, fixing CMake 4.x incompatibility - cmake/matstruct_dependencies.cmake: disable polyscope on HPC where libXinerama/libXrandr headers are not available Tested on Rocky Linux 8.10 with CUDA 11.7 and GCC 9.4. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tput-dir - Wrap all polyscope includes and calls in #ifdef MATSTRUCT_WITH_VISUALIZATION guards in main_gui.cxx and main_voronoi.cpp; add CMake option (default OFF) - Add release_pointers() to OPT_RPD and MainGuiWindow; call them before stack unwinds in main() to prevent destructors deleting stack-allocated objects - Add -d/--output-dir CLI arg (default ../out) via g_output_dir global in io_wrapper; replace all hardcoded "../out/" paths with g_output_dir + "/" - Switch build type to RelWithDebInfo for GDB-usable backtraces Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4/5/2026 : 12:50 Alireza Khatami