Homework#1
Open
nimeshmino wants to merge 3 commits into
Open
Conversation
pivee
requested changes
Jan 5, 2023
| * Write a function that joins two strings | ||
| */ | ||
|
|
||
| function newFunction() {} No newline at end of file |
Collaborator
There was a problem hiding this comment.
Try to have fewer comments in your code, but always try to make the codebase readable, and comprehensible by giving meaningful names to the functions and variables. In this scenario, you could name the function to be something like joinTextStrings so that it tells the reader what it does.
Also keep in mind that you shouldn't be too specific either. For example, if you name the function to be joinTwoTextStrings, then if you have to extend this functionality to join three, then it makes things complex.
Once you switch to TypeScript, using good-practices will become even easier. That would help you to write something like the following snippet:
/**
* Takes an array of strings, joins them using " " characters between each,
* and returns the result as a string.
*/
function joinTextStrings(textStrings: string[]): string {
return textStrings.join(" ");
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.