Implement textDocument/diagnostic pull method - #44
Merged
Conversation
Return stored diagnostics when the client requests them via the pull diagnostic model (LSP 3.17.0+), instead of returning "method not found". This complements the existing push model (publishDiagnostics) and fixes errors in editors like Zed that use pull diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return stored diagnostics when the client requests them via the pull diagnostic model (LSP 3.17.0+), instead of returning "method not found". This complements the existing push model (
publishDiagnostics).Problem: Editors like Zed that use pull diagnostics log repeated errors:
The server already advertises
diagnostic_providerin its capabilities and computes diagnostics ondid_open/did_change, but thediagnostictrait method was not overridden, so the default implementation returnedError::method_not_found().Fix: Override the
diagnosticmethod to return the already-computed diagnostics for the requested document as aFullDocumentDiagnosticReport. If no diagnostics exist for the URI, an empty report is returned.