Skip to content

Fixed required check #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niels-nijens merged 4 commits into from
Jul 3, 2026
Merged

Fixed required check #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c39e52b
Fixed required check in \Nijens\OpenapiBundle\Validation\RequestValid…
jvdhehvg Jul 1, 2026
e5016ec
Normalize booleanish query parameters in RequestParameterValidator
jvdhehvg Jul 1, 2026
5d0ecdc
Apply suggestion from @niels-nijens
jvdhehvg Jul 2, 2026
bf96b67
Fixed variable name
jvdhehvg Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Validation/RequestValidator/RequestParameterValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ private function getValidateQueryParametersFromRequest(Request $request): array
private function validateQueryParameter(Request $request, string $parameterName, stdClass $parameter): array
{
$violations = [];
if ($request->query->has($parameterName) === false && $parameter->required ?? false) {
if (($parameter->required ?? false) && $request->query->has($parameterName) === false) {
$violations[] = new Violation(
'required_query_parameter',
sprintf('Query parameter %s is required.', $parameterName),
Expand All @@ -93,6 +93,9 @@ private function validateQueryParameter(Request $request, string $parameterName,
}

$parameterValue = $request->query->get($parameterName);
if ($parameter->schema->type === 'boolean') {
$parameterValue = $request->query->getBoolean($parameterName, $parameter->schema->default ?? false);
}

$this->jsonValidator->validate($parameterValue, $parameter->schema, Constraint::CHECK_MODE_COERCE_TYPES);
if ($this->jsonValidator->isValid()) {
Expand Down
48 changes: 48 additions & 0 deletions tests/Validation/RequestValidator/RequestParameterValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,29 @@ public function testCannotValidateRequiredRequestParameterWithoutValue(): void
);
}

public function testCanValidateOptionalRequestParameterWithoutRequiredFlag(): void
{
$request = new Request();
$request->attributes->set(
RouteContext::REQUEST_ATTRIBUTE,
[
RouteContext::REQUEST_VALIDATE_QUERY_PARAMETERS => [
'foo' => json_encode([
'name' => 'foo',
'in' => 'query',
'schema' => [
'type' => 'string',
],
]),
],
]
);

static::assertNull(
$this->validator->validate($request)
);
}

public function testCanValidateRequestParameterOfTypeBoolean(): void
{
$request = new Request();
Expand All @@ -116,6 +139,31 @@ public function testCanValidateRequestParameterOfTypeBoolean(): void
);
}

public function testCanValidateRequestParameterOfTypeBooleanWithOne(): void
{
$request = new Request();
$request->query->set('foo', '1');
$request->attributes->set(
RouteContext::REQUEST_ATTRIBUTE,
[
RouteContext::REQUEST_VALIDATE_QUERY_PARAMETERS => [
'foo' => json_encode([
'name' => 'foo',
'in' => 'query',
'required' => true,
'schema' => [
'type' => 'boolean',
],
]),
],
]
);

static::assertNull(
$this->validator->validate($request)
);
}

public function testCanValidateRequestParameterOfTypeString(): void
{
$request = new Request();
Expand Down
Loading