added optional appended salt for checksum calculation#56
Open
JoeChester wants to merge 1 commit into
Open
Conversation
nicoulaj
requested changes
Jun 1, 2018
nicoulaj
left a comment
nicoulaj
left a comment
Owner
There was a problem hiding this comment.
Thanks! see my comment on CRC32
| { | ||
| throw new DigesterException( "Unable to read " + file.getPath() + ": " + e.getMessage() ); | ||
| try { | ||
| byte[] bytes = IOUtils.toByteArray(new FileInputStream(file)); |
Owner
There was a problem hiding this comment.
This will load the whole file in memory, also there are several unneeded array copies, I think this can be done without much overhead but just chaining the file input stream with a salt ByteArrayInputStream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see below...