Add support for include and exclude patterns for project dependencies#113
Open
tombueng wants to merge 2 commits into
Open
Add support for include and exclude patterns for project dependencies#113tombueng wants to merge 2 commits into
tombueng wants to merge 2 commits into
Conversation
Add support for include and exclude patterns for project dependencies nicoulaj#36 nicoulaj#36
Add support for include and exclude patterns for project dependencies nicoulaj#36 nicoulaj#36
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
============================================
+ Coverage 78.36% 78.62% +0.25%
Complexity 188 188
============================================
Files 27 27
Lines 661 669 +8
Branches 77 77
============================================
+ Hits 518 526 +8
Misses 112 112
Partials 31 31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nicoulaj
requested changes
May 14, 2021
nicoulaj
left a comment
nicoulaj
left a comment
Owner
There was a problem hiding this comment.
The naming of the new parameters is a bit inconsistent with the existing one: includeClassifiers. Would you mind renaming to includeGroupIds / etc ?
Author
|
Sure!
Viele Grüße
Thomas Büngener
…________________________________
From: nicoulaj ***@***.***>
Sent: Friday, May 14, 2021 8:28:25 PM
To: nicoulaj/checksum-maven-plugin ***@***.***>
Cc: Thomas Büngener ***@***.***>; Author ***@***.***>
Subject: Re: [nicoulaj/checksum-maven-plugin] Add support for include and exclude patterns for project dependencies (#113)
@nicoulaj requested changes on this pull request.
The naming of the new parameters is a bit inconsistent with the existing one: includeClassifiers. Would you mind renaming to includeGroupIds / etc ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#113 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAWHWSQE5OVKLEEXCIDY6T3TNVTUTANCNFSM44Y4QKJQ>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the following feature request: #36