Skip to content

clean internal nodes on remove#17

Merged
nicolaskagami merged 4 commits into
mainfrom
nsk/clean-nodes-on-remove
Mar 14, 2026
Merged

clean internal nodes on remove#17
nicolaskagami merged 4 commits into
mainfrom
nsk/clean-nodes-on-remove

Conversation

@nicolaskagami

@nicolaskagami nicolaskagami commented Mar 13, 2026

Copy link
Copy Markdown
Owner

What does this PR add?

  • Cleans empty internal nodes on remove

closes #9

Details

  • An argument could be made that it's not worth it to proactively clean these entries, as the original poptrie does. However, this is more in line with the other design choices.
  • Added a regression test for when checking a removed entry from a parent that would've had the same stride id after removing a child node.

@nicolaskagami nicolaskagami changed the title Nsk/clean nodes on remove clean internal nodes on remove Mar 13, 2026
@nicolaskagami
nicolaskagami merged commit 70c4166 into main Mar 14, 2026
1 check passed
@nicolaskagami
nicolaskagami deleted the nsk/clean-nodes-on-remove branch March 14, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement node cleanup on remove

1 participant