make poptrie generic over Prefix instead of Key#10
Merged
Conversation
nicolaskagami
force-pushed
the
nsk/prefix-key
branch
from
March 10, 2026 01:09
b5b2b92 to
3743c77
Compare
nicolaskagami
changed the title
Prefix instead of Key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR add?
Prefixas the new "key" generic forPoptrieAddressis now the name for the oldKey.closes #2
Details
Addressby changing theextract*functions to be methods ofAddressbut couldn't keep performance like that. This will be revisited.