fix: correct changelog ordering, add node_modules to gitignore, button types + symlink check - #66
Open
fix2015 wants to merge 1 commit into
Open
Conversation
…n types + symlink check changelog had 0.4.3 and 0.4.4 swapped — fixed the ordering so it reads newest-first like the rest of the file. also: - added node_modules/ to .gitignore (was missing) - added type="button" on the zoom control buttons in slide-deck template so they don't accidentally trigger form submissions - moved the symlink security check before mkdirSync in extension.ts — previously it was checking after creating the directory, which defeats the purpose if the path is already a symlink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the changelog had versions 0.4.3 and 0.4.4 in the wrong order — swapped them so it reads newest-first like the rest of the file.
A few other small things:
node_modules/wasn't in.gitignoretype="button", so they default tosubmitwhich can cause unexpected behavior inside formsextension.tswas running aftermkdirSync— moved it before so it actually catches symlinked output directories before anything gets written