fix: reset error on http-request retry#263
Open
simonostendorf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an API request fails with a
401 Unauthorizedand the client successfully refreshes the token and retries the request, the retried request may return a200 OKwith valid data, but the error is still returned. This is because the error fields (ErrorStatus,Error,ErrorMessage) are populated from the first failed response and are never cleared before the retry.The following log output illustrates the issue. The first request fails with a 401, the token is refreshed, the retry succeeds with a 200 and valid data but the user still receives
status=401 error=Unauthorized message=Invalid OAuth token:Root Cause
In
doRequest, when a 401 response is received, the error body is deserialized intoresp, settingresp.ErrorStatus,resp.Error, andresp.ErrorMessage. The client then refreshes the token andcontinues the loop. On the next iteration the request succeeds andresp.Datais populated correctly, but nothing resets the error fields from the previous iteration. TheResponsestruct ends up in a mixed state: valid data alongside a stale 401 error.