(from RedmineX)

Fork of Redmine CK Editor plugin

Source:

https://github.com/a-ono/redmine_ckeditor

Version

Based on 1.2.3

Reason:

After navigating to plugin settings of CK Editor, internal server error (500) occured. This was due to missing variable ckeditor_javascripts in the view template. This is a know problem - see a-ono#308 for more details.

Changes:

• 'app/views/settings/_ckeditor.html.erb' - line 1 - missing variable ckedittor_javascripts was replaced by RedmineCkeditor::Helper.instance_method(:ckeditor_javascripts).bind(self).call as recomended in the issue 308 (a-ono#308).
• 'lib/redmine_ckeditor/application_helper_patch.rb' - method format_activity_description was wrapped in def self.included(base) and base.class_eval do. Before this fix this method was correctly redefined only if no other Application Helper patches were present. Because we have many Application Helper patches in Projectino and RedmineX solutions, this redefinition did not work correctly.
• assets/ckeditor - version of CK Editor (which is part of the plugin) was upgraded to 4.15.1 (it is the last v4 version). This version enables copy/paste functionality also in Chrome browser for Android.

Changes due to CK Editor upgrade to 4.15.1

• 'assets/ckeditor/config.js' - line 7 - all required plugins added to the config.options object. Part of the CK Editor 4.15.1 is also exportpdf plugin, which is a premium (paid) feature. This means we need to disable the plugin. This can be (theoretically) done by the removePlugins object, however this configuration did not work and therefore config.options was used instead.

Changes for Redmine version 5.X.X support

• 'init.rb' - lines 2 to 7 - this block of code replaced original require 'redmine_ckeditor' statement. This code ensures support of zeitwerk loader used in Redmine 5.X.X.
• lib/redmine_ckeditor.rb - lines 141 to 150 - paths to required modules were updated inorder to support loading by the zeitwerk loader used in Redmine 5.X.X.
• lib/redmine_ckeditor/pdf_patch.rb - line 2 and line 51 - name of this module was changed from PDFPatch to PdfPatch in order to respect Ruby naming conventions (this is also strictly required byt the zeitwerk loader used in Redmine 5.X.X).
• lib/redmine_ckeditor/wiki_formatting/formatter.rb - lines 27 to 37 - ActionView::Base object in Rails 6.X used in Redmine 5.X.X as default does not contain originally used white_list_sanitizer method which was deprecated. The original code was replaced by if statement which uses correct method depending on the Rails version.