Skip to content

Inclusion of changes to matcher.py including Barnes averaging#55

Open
swnesbitt wants to merge 17 commits into
nguy:masterfrom
swnesbitt:master
Open

Inclusion of changes to matcher.py including Barnes averaging#55
swnesbitt wants to merge 17 commits into
nguy:masterfrom
swnesbitt:master

Conversation

@swnesbitt

Copy link
Copy Markdown
Contributor

This fork includes Barnes averaging around the aircraft position in the radar matching. Testing by @joefinlon.

Comment thread awot/util/matcher.py
ind1d.append(prind1d)

for field in pr.fields.keys():
# prdata[field]['data'].flat[indt[0]] = \

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to retain this commented out field?

Comment thread awot/util/matcher.py

for field in pr.fields.keys():
prdata[field]['data'][indt[0]] = dfield[field][prind1d]
if Barnes:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice addition @swnesbitt

@nguy

nguy commented Mar 13, 2018

Copy link
Copy Markdown
Owner

Could you either add .DS_Store to the main level .gitignore file or if you have a global (https://stackoverflow.com/questions/107701/how-can-i-remove-ds-store-files-from-a-git-repository). You might also have to do do a quick git rm .DS_Store so that these don't come along with the PR.

Comment thread awot/util/matcher.py
start_time=None, end_time=None,
ac_rng=None, ac_az=None, ac_elev=None):
ac_rng=None, ac_az=None, ac_elev=None, matchinfo=None):
'''

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a short docstring for matchinfo to describe usage?

Comment thread awot/util/write_kmz.py
import simplekml
except:
raise ValueError("This module requires installation of simplekml...")
# return

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this return needs to be here as it's an import test. Commented out, but maybe we should remove to clear up any confusion later.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you found these kmz writers to be useful?

@nguy

nguy commented Mar 13, 2018

Copy link
Copy Markdown
Owner

If you want, add @joefinlon to the contributors list (and anyone else). Otherwise, I can do that when I assign a DOI after this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants