Fix Tormented Demons#128
Merged
Merged
Conversation
Lexer747
force-pushed
the
pr-tormented-demons
branch
from
April 13, 2026 22:33
071b674 to
4f32bf3
Compare
ngraves95
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
So I was doing a tormented demon task and the punish tracking just wasn't working. When I originally added it #73 I thought I mapped the entire underground region, however upon inspection my mapping was just rubbish 😅
Instead it's just more robust to just check against the TD id and drop any map checking (and more efficient?), Scurrius was my original inspiration in which case the area is required because the bone weapons are not 1 tick outside of the are. But this same logic doesn't apply to TDs which are the unique thing which tells the plugin to care.
The fix is tiny but the tests needed a bit of re-factoring which bloated the size of this PR.
Testing
I added a unit test :)
java_1GNntDgDr8.mp4