Add setting for zero-based tick counting#124
Conversation
|
Testing is not optional. I'm personally ok with an extra choice and counting to 1 or 0 are both fine (so on premise this PR and code is fine). You need to check that the attack bar works with this correctly, the plugin is still flakey and the test suite isn't good enough to for me to trust this without testing. |
|
I have configured a testing environment locally and also included |
|
@Lexer747 I have updated the description of the PR with some gifs of the plugin in action and the updated settings screen after testing it within RuneLite. |
|
Can you revert e6368ad the way to run tests is just Thanks for the testing, looks good, I'll take a look at getting merged once you've reverted that commit :) |
This reverts commit e6368ad.
|
Thanks! Just reverted the commit :) |
Summary
This change adds a setting to use zero-based tick counts for the tile display.
This means that for a 3-tick weapon, the count will be
2-1-0-2-1-0instead of3-2-1-3-2-1.The reason for adding this is that this is more intuitive for prayer flicking, where the count can be interpreted as "amount of ticks before you should enable prayers for the next attack"
Testing
Tested with zero-based enabled and disabled, tested the number counter as well as the bar and both combined.
Settings:
Zero-based counting disabled:
Zero-based counting enabled:
Zero-based counting enabled, as well as the bar enabled: