Skip to content

Add setting for zero-based tick counting#124

Merged
Lexer747 merged 3 commits into
ngraves95:mainfrom
lucianonooijen:main
Apr 2, 2026
Merged

Add setting for zero-based tick counting#124
Lexer747 merged 3 commits into
ngraves95:mainfrom
lucianonooijen:main

Conversation

@lucianonooijen

@lucianonooijen lucianonooijen commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Summary

This change adds a setting to use zero-based tick counts for the tile display.

This means that for a 3-tick weapon, the count will be 2-1-0-2-1-0 instead of 3-2-1-3-2-1.

The reason for adding this is that this is more intuitive for prayer flicking, where the count can be interpreted as "amount of ticks before you should enable prayers for the next attack"

Testing

Tested with zero-based enabled and disabled, tested the number counter as well as the bar and both combined.

Settings:

plugin-settings

Zero-based counting disabled:

disabled

Zero-based counting enabled:

enabled

Zero-based counting enabled, as well as the bar enabled:

enabled_with_bar

@Lexer747

Copy link
Copy Markdown
Collaborator

Testing is not optional. I'm personally ok with an extra choice and counting to 1 or 0 are both fine (so on premise this PR and code is fine). You need to check that the attack bar works with this correctly, the plugin is still flakey and the test suite isn't good enough to for me to trust this without testing.

@lucianonooijen

Copy link
Copy Markdown
Contributor Author

I have configured a testing environment locally and also included ./gradlew.bat run to work for testing

@lucianonooijen

Copy link
Copy Markdown
Contributor Author

@Lexer747 I have updated the description of the PR with some gifs of the plugin in action and the updated settings screen after testing it within RuneLite.

@Lexer747

Lexer747 commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Can you revert e6368ad the way to run tests is just ./gradlew test

Thanks for the testing, looks good, I'll take a look at getting merged once you've reverted that commit :)

@lucianonooijen

Copy link
Copy Markdown
Contributor Author

Thanks! Just reverted the commit :)

@Lexer747
Lexer747 merged commit 1f73eb0 into ngraves95:main Apr 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants