Add pre plugin hub check#122
Merged
Merged
Conversation
Lexer747
marked this pull request as ready for review
March 27, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I tried updating the plugin and it failed the build https://github.com/runelite/plugin-hub/actions/runs/23667936770/job/68954498085?pr=11247 therefore lets add these checks to our own CI so I don't waste the hub maintainers time. And these errors are caught early.
For now this PR only adds the
build.gradleline length check.Testing
Here's the check catching the gradle file being too big https://github.com/ngraves95/attacktimer/actions/runs/23668236125/job/68955489864
Then the build passing after the second commit made the gradle file longer and less wide.
https://github.com/Lexer747/attacktimer/actions/runs/23668407817/job/68956053085