8.1.2#1132
Merged
Merged
Conversation
blizzz
approved these changes
Jun 1, 2026
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
what's the root cause? DI hell?
AndyScherzinger
approved these changes
Jun 1, 2026
Member
Author
the event triggers a listener in Guest which expect the session to be set. But it seems that while we setup the session just before triggering the listener it is only fully set after the redirect. I need to investigate this a bit more, but reverting the commit fixes the issue for now |
AndyScherzinger
approved these changes
Jun 1, 2026
This reverts commit 0890d21. Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
AndyScherzinger
force-pushed
the
carl/8.1.2
branch
from
756a91c to
14d3dbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.