Skip to content

feat: Trigged UserLoggedInEvent when user log in#1072

Merged
CarlSchwan merged 1 commit into
masterfrom
carl/userloggedinevent
May 29, 2026
Merged

feat: Trigged UserLoggedInEvent when user log in#1072
CarlSchwan merged 1 commit into
masterfrom
carl/userloggedinevent

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

Took over from #851

We don't need all the events from that merge requests as some of these are already triggered by other methods (e.g. logout event is triggered in userSession->logout())

@CarlSchwan CarlSchwan self-assigned this Apr 15, 2026
@CarlSchwan CarlSchwan requested a review from blizzz as a code owner April 15, 2026 22:49
@CarlSchwan CarlSchwan force-pushed the carl/userloggedinevent branch 2 times, most recently from 5d65384 to ef781e3 Compare April 15, 2026 23:30
Copy link
Copy Markdown
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative would be to call User\Session::completeLogin which does the same, and also would trigger user home init on first login and such, could then be avoided here. Not sure why we do not have it, possibly because it is not exposed in an API.

@CarlSchwan CarlSchwan force-pushed the carl/userloggedinevent branch 6 times, most recently from 2e00ed2 to 3f59b39 Compare April 20, 2026 11:17
@CarlSchwan CarlSchwan force-pushed the carl/userloggedinevent branch from 3f59b39 to e30920f Compare May 29, 2026 10:35
Co-Authored-By: Malik Mann <github@dermm.io>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/userloggedinevent branch from e30920f to 0890d21 Compare May 29, 2026 14:02
@CarlSchwan CarlSchwan enabled auto-merge May 29, 2026 14:15
@CarlSchwan CarlSchwan merged commit 73f14a8 into master May 29, 2026
56 checks passed
@CarlSchwan CarlSchwan deleted the carl/userloggedinevent branch May 29, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants