fix: migrate typing state to Pinia#18297
Open
Antreesy wants to merge 4 commits into
Open
Conversation
Contributor
|
why in chat extras? I would expect it is related to participant entity hence a specific store for it |
Contributor
Author
|
Maybe you're right, it doesn't belong to chat extras.. |
- while participants store is not migrated to pinia yet, eager import causing a dependencies loop (store -> pinia -> store), while they are not initialized yet AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
feat/extract-typing-to-pinia
branch
from
7a80b0d to
06ce331
Compare
DorraJaouad
approved these changes
Jun 12, 2026
This reverts commit 7ba09df.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Contributor
Author
|
Moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
No changes
🏁 Checklist