Skip to content

fix(ui): simplify signaling server error toast for non-admins #17322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShGKme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): simplify signaling server error toast for non-admins #17322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/utils/signaling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { getCurrentUser } from '@nextcloud/auth'
import axios, { isCancel } from '@nextcloud/axios'
import {
showError,
Expand Down Expand Up @@ -1123,12 +1124,22 @@ Signaling.Standalone.prototype.helloResponseReceived = function(data) {
|| (!this.hasFeature('switchto') && hasTalkFeature('local', 'breakout-rooms-v1')) // Talk v16
|| (!this.hasFeature('federation') && hasTalkFeature('local', 'federation-v2')) // Talk v20
)) {
showError(
t('spreed', 'The configured signaling server needs to be updated to be compatible with this version of Talk. Please contact your administration.'),
{
timeout: TOAST_PERMANENT_TIMEOUT,
},
)
if (getCurrentUser()?.isAdmin) {
showError(
t('spreed', 'The configured signaling server needs to be updated to be compatible with this version of Talk'),

@Antreesy Antreesy Mar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're changing the string, i would even rewrite it to High-performance backend needs to be updated...

@nickvergessen nickvergessen Apr 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShGKme want to fix this?

@nimishavijay nimishavijay May 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds much simpler, I would vote for this, but remove the ellipses? Just High-performance backend needs to be updated. should be enough

{
timeout: TOAST_PERMANENT_TIMEOUT,
},
)
} else {
showError(
t('spreed', 'The server is misconfigured. Please contact your administration.'),
Comment thread
nickvergessen marked this conversation as resolved.
{
timeout: TOAST_PERMANENT_TIMEOUT,
},
)
}

console.error('The configured signaling server needs to be updated to be compatible with this version of Talk. Please contact your administration.')
}

Expand Down