refactor(log): clarify LogDetails timestamp and message normalization paths#61170
Draft
joshtrichards wants to merge 2 commits into
Draft
refactor(log): clarify LogDetails timestamp and message normalization paths#61170joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
…clarity Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
LogDetails::logDetails()for clarity without changing behavior.This makes the method easier to follow by splitting timestamp creation into named steps, replacing
compact()with an explicit entry array, and normalizing array messages before building the final log entry.Changes
$timeas both aDateTimeand formatted stringcompact()with an explicit associative arrayBehavior
No intended functional changes. Existing timestamp, timezone fallback, and message normalization behavior is preserved.
Checklist
3. to review, feature component)stable32)AI (if applicable)