Skip to content

Fix deprecations in tests#61140

Open
come-nc wants to merge 30 commits into
masterfrom
fix/fix-deprecations-in-tests
Open

Fix deprecations in tests#61140
come-nc wants to merge 30 commits into
masterfrom
fix/fix-deprecations-in-tests

Conversation

@come-nc

@come-nc come-nc commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Fix deprecations from PHP or phpunit in the test suite
  • Exclude groups of tests rather than rely on autoskip for non-configured stuff
  • Display skipped tests to keep it under control
  • Type IUser strictly to improve mocking
  • Add strict types in other places where it improves testing
  • Re-enable tests that were disabled on drone a long time ago
  • Correctly setup apcu, memcached and redis to test them -> postponed
  • Make sure setup-php fails when a module fails to enable

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@come-nc come-nc added the 2. developing Work in progress label Jun 10, 2026
@come-nc come-nc added this to the Nextcloud 35 milestone Jun 10, 2026
@come-nc come-nc changed the title Fix/fix deprecations in tests Fix deprecations in tests Jun 10, 2026
@come-nc come-nc force-pushed the fix/fix-deprecations-in-tests branch from 71d3fbe to ac436dd Compare June 10, 2026 14:48
@Altahrim Altahrim force-pushed the fix/fix-deprecations-in-tests branch from 1b4f97f to fcc703d Compare June 10, 2026 15:34
Altahrim and others added 23 commits June 10, 2026 18:02
@Altahrim @come-nc
chore(deprecated): remove imagedestroy as it's noop since PHP 8.0
65c5961 
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim @come-nc
chore(deprecated): remove Reflection*::setAccessible as it's noop sin…
8d57774 
…ce PHP 8.1

Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore(tests): Avoid deprecation in PublicKeyTokenProvider
816f90a 
Also cleaned up the test a bit.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore(tests): Fix User UID mocking in TwoFactorAuth/ManagerTest.php
5fc9f76 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim @come-nc
chore(L10N): add strict types in L10N::localeExists
7ce4f8b 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim @come-nc
chore: add strict types in IAddressBook::getKey
f46b687 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore: List skipped tests in PHPUnit output
fd8db53 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
fix(cache): Improve typing of ICache and CappedMemoryCache
85e68d5 
For CappedMemoryCache we allow string|int to be consistent with PHP
 array keys, for ICache we strictly apply the previously stated string
 type for keys.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore: Exclude skipped groups from nodb test suite
3948859 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore: Re-enable tests failing on drone
63315cd 
We do not use drone anymore, let’s see if we can fix these tests or if
 they should be removed.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore: Exclude S3 groups from test:db composer command
1db5a21 
These groups need a specific setup and are not supported by our main DB
 testing workflows.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim @come-nc
chore(workflows): add APCu extension on no db tests
185f206 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore(tests): Set a token string to avoid getToken returning null fro…
467792e 
…m tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim @come-nc
chore(users): add stricter return types to IUser
25a3222 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
fix: Add explicit getToken method for PublicKeyToken entity
bc44af5 
This allows mocking the method in tests, and makes sure typing is
 respected

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
fix: Silence PHP warnings from fopen and mkdir
d75b903 
We are testing the result and logging our own error anyway.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore: Update guest avatar test image
aec0377 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore: Fix test in user_ldap passing wrong type
c64c236 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore: Pass correct type for alias in QueryBuilderTest
be96250 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore(tests): Exclude files_external tests from default testsuite
52d38d0 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim @come-nc
chore(tests): enable setup-php failure on deps
c25d442 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore(tests): Adapt tests to IUser strict typing
aae83db 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
fix(dav): Remove useless null check on displayName
1e3d541 
There is already a fallback to uid inside User.php

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
come-nc added 4 commits June 10, 2026 18:05
@come-nc
chore(tests): Fix typo resulting in tests issue
094007a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore: Enable sqlite CI testing again
6a82921 
It was restricted to a single test by mistake in 4b01556

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@come-nc
chore(tests): Speed up TARTest by compressing a smaller folder
947dcbb 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Fix data directory permission check and its test
f1976d4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/fix-deprecations-in-tests branch from 61e16d7 to f1976d4 Compare June 10, 2026 16:06
@come-nc come-nc marked this pull request as ready for review June 10, 2026 16:06
@come-nc come-nc requested review from CarlSchwan, leftybournes, provokateurin and salmart-dev and removed request for a team June 10, 2026 16:06
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 10, 2026
come-nc added 2 commits June 10, 2026 22:56
@come-nc
chore: Fix psalm issues following strong typing of IUser
35800f3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore(tests): Use /dev/shm as a tempdirectory
c0080e0 
Should fix tests in phpunit-32bits

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/fix-deprecations-in-tests branch from 4c64027 to c0080e0 Compare June 10, 2026 20:57
@come-nc
tmp
bb544c4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc

come-nc commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

We need the docker image for php32bit CI to be modified to not run as root for the permission tests to work.
AlgorithmTest looks flaky, I have no idea why 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

@come-nc come-nc

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

3 participants

@come-nc @Altahrim @miaulalala