Skip to content

test(dav): fix availability replacement picker selectors #61110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pringelmann wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −10
Draft

test(dav): fix availability replacement picker selectors #61110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3ed5d0
test(dav): fix availability replacement picker selectors
pringelmann Jun 9, 2026
55a18b7
test(systemtags): open tag dropdowns with click to fix flaky option l…
pringelmann Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cypress/e2e/appstore/apps.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,7 @@ describe('Settings: App management', { testIsolation: true }, () => {
cy.findByRole('dialog')
.should('be.visible')
.within(() => {
cy.get('input')
.should('be.focused')
cy.findByRole('combobox')
.type('admin')
})
cy.findByRole('option', { name: /admin/ })
Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/dav/availability.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ describe('Calendar: Availability', { testIsolation: true }, () => {
.type('Happy holidays!')

cy.intercept('GET', '**/ocs/v2.php/apps/files_sharing/api/v1/sharees?*search=replacement*').as('userSearch')
cy.findByRole('searchbox')
cy.findByRole('combobox', { name: /Out of office replacement/ })
.should('be.visible')
.as('userSearchBox')
.click()
Expand Down Expand Up @@ -122,7 +122,7 @@ describe('Calendar: Availability', { testIsolation: true }, () => {
.should('have.value', 'Vacation')
cy.findByRole('textbox', { name: /Long absence/ })
.should('have.value', 'Happy holidays!')
cy.findByRole('combobox')
cy.get('#absence')
.should('contain.text', 'replacement-user')
})
})
12 changes: 6 additions & 6 deletions cypress/e2e/systemtags/admin-settings.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('Create system tags', () => {
cy.wait('@createTag').its('response.statusCode').should('eq', 201)

// see that the created tag is in the list
cy.get('input#system-tags-input').focus()
cy.get('input#system-tags-input').click()
cy.get('input#system-tags-input').invoke('attr', 'aria-controls').then((id) => {
cy.get(`ul#${id} li span[title="${tagName}"]`)
.should('exist')
Expand All @@ -52,7 +52,7 @@ describe('Update system tags', { testIsolation: false }, () => {
})

it('select the tag', () => {
cy.get('input#system-tags-input').focus()
cy.get('input#system-tags-input').click()
cy.get('input#system-tags-input').invoke('attr', 'aria-controls').then((id) => {
cy.get(`ul#${id} li span[title="${tagName}"]`).should('exist').click()
})
Expand All @@ -69,7 +69,7 @@ describe('Update system tags', { testIsolation: false }, () => {
cy.get('input#system-tag-name').type(updatedTagName)
cy.get('input#system-tag-name').should('have.value', updatedTagName)
// select the new tag level
cy.get('input#system-tag-level').focus()
cy.get('input#system-tag-level').click()
cy.get('input#system-tag-level').invoke('attr', 'aria-controls').then((id) => {
cy.get(`ul#${id} li span[title="Invisible"]`).should('exist').click()
})
Expand All @@ -80,7 +80,7 @@ describe('Update system tags', { testIsolation: false }, () => {
})

it('see the tag was successfully updated', () => {
cy.get('input#system-tags-input').focus()
cy.get('input#system-tags-input').click()
cy.get('input#system-tags-input').invoke('attr', 'aria-controls').then((id) => {
cy.get(`ul#${id} li span[title="${updatedTagName} (invisible)"]`)
.should('exist')
Expand All @@ -97,7 +97,7 @@ describe('Delete system tags', { testIsolation: false }, () => {

it('select the tag', () => {
// select the tag to edit
cy.get('input#system-tags-input').focus()
cy.get('input#system-tags-input').click()
cy.get('input#system-tags-input').invoke('attr', 'aria-controls').then((id) => {
cy.get(`ul#${id} li span[title="${updatedTagName} (invisible)"]`).should('exist').click()
})
Expand All @@ -118,7 +118,7 @@ describe('Delete system tags', { testIsolation: false }, () => {
})

it('see that the deleted tag is not present', () => {
cy.get('input#system-tags-input').focus()
cy.get('input#system-tags-input').click()
cy.get('input#system-tags-input').invoke('attr', 'aria-controls').then((id) => {
cy.get(`ul#${id} li span[title="${updatedTagName}"]`).should('not.exist')
})
Expand Down
Loading