[stable34] Fix rendering custom columns in file lists#60525
Open
backportbot[bot] wants to merge 3 commits into
Open
[stable34] Fix rendering custom columns in file lists#60525backportbot[bot] wants to merge 3 commits into
backportbot[bot] wants to merge 3 commits into
Conversation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
CustomElementRender is used to render both IFileActions and IColumns. However, the API to render both of them is different, and currently CustomElementRender passes the arguments expected by IFileAction. Fortunately those arguments are a superset of those expected by IColumn, so they can be adapted when a CustomElementRender is used to render an IColumn. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
backportbot
Bot
added
bug
3. to review
Member
|
/compile amend / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/60134/stable34
branch
from
4819250 to
d7e60c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #60134