Skip to content

[stable33] Fix error when creating mail shares if custom tokens are enabled#60509

Merged
danxuliu merged 2 commits into
stable33from
backport/60378/stable33
May 19, 2026
Merged

[stable33] Fix error when creating mail shares if custom tokens are enabled#60509
danxuliu merged 2 commits into
stable33from
backport/60378/stable33

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented May 18, 2026

Backport of #60378

@backportbot backportbot Bot requested review from danxuliu, nfebe and susnux May 18, 2026 14:17
@backportbot backportbot Bot added this to the Nextcloud 33.0.4 milestone May 18, 2026
When a new share is saved it is first created in the backend and then
updated with some additional attributes set in the frontend. If custom
tokens are enabled the attributes to update also include the token.
However, for new shares the token is set by the backend when it is
created, it is not defined by the frontend, so the token returned by the
backend needs to be copied to the share data in the frontend. Otherwise
the update would fail because an empty token is sent.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu force-pushed the backport/60378/stable33 branch from 0072c93 to 4f58d49 Compare May 18, 2026 14:21
@danxuliu
Copy link
Copy Markdown
Member

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@danxuliu danxuliu marked this pull request as ready for review May 18, 2026 15:46
@danxuliu danxuliu requested review from a team as code owners May 18, 2026 15:46
@danxuliu danxuliu requested review from ArtificialOwl, come-nc, skjnldsv and sorbaugh and removed request for a team May 18, 2026 15:46
Copy link
Copy Markdown
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@danxuliu danxuliu merged commit d51198c into stable33 May 19, 2026
149 of 154 checks passed
@danxuliu danxuliu deleted the backport/60378/stable33 branch May 19, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants