fix(OC_Helper): properly calculate quota of shared storages#60341
Merged
Conversation
susnux
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
provokateurin
requested changes
May 13, 2026
provokateurin
approved these changes
May 13, 2026
Contributor
Author
|
/backport to stable34 |
Contributor
Author
not direct. It should do the same (rebase) in the new code. |
susnux
force-pushed
the
fix/quota-calc-share
branch
2 times, most recently
from
3e6380c to
7d48498
Compare
- resolves #55659 First we need to properly handle shared storages, because there the quota is the quota of the user who owns the nodes, not the user who shared the nodes. Second if no user can be fetched then we cannot get the global storage info, thus in this case (public share?) we need to safe-guard. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/quota-calc-share
branch
from
7d48498 to
29fc48e
Compare
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First we need to properly handle shared storages,
because there the quota is the quota of the user who owns the nodes, not the user who shared the nodes.
Second if no user can be fetched then we cannot get the global storage info, thus in this case (public share?) we need to safe-guard.
Checklist
3. to review, feature component)stable32)AI (if applicable)