Skip to content

Revert "Do not do redirect handling when loggin out"#40407

Open
haslersn wants to merge 1 commit into
nextcloud:masterfrom
haslersn:revert-pr-12573
Open

Revert "Do not do redirect handling when loggin out"#40407
haslersn wants to merge 1 commit into
nextcloud:masterfrom
haslersn:revert-pr-12573

Conversation

@haslersn

Copy link
Copy Markdown

This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: #16310

Checklist

@kesselb kesselb added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Sep 14, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Sep 14, 2023
@kesselb

kesselb commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Good finding 👍

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@haslersn

haslersn commented Nov 2, 2023

Copy link
Copy Markdown
Author

What's keeping this from getting merged?

@nickvergessen nickvergessen requested review from kesselb and removed request for rullzer November 2, 2023 09:59
@kesselb

kesselb commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

What's keeping this from getting merged?

The failing DCO check, for example.
Please rebase your branch (to pull in the latest changes from master) and sign off the commits (to pass the DCO check).

@haslersn

haslersn commented Nov 2, 2023

Copy link
Copy Markdown
Author

@kesselb is was signed off, but apparently there was a mismatch between committer email and sign-off email. Should be fixed now.

This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
@haslersn

Copy link
Copy Markdown
Author

What's now keeping this from getting merged?

@come-nc

come-nc commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

I rebased for CI, I do not understand enough about this for approving, I’ll follow @kesselb lead on this one.

@kesselb

kesselb commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

Hello Hello, it's been a while and I don't remember all the details. I think the middleware was added to address the redirect cause by clear-site-data executionContext and can, as we removed executionContext again, go.

This was referenced Sep 25, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
This was referenced Jan 29, 2026
This was referenced Feb 11, 2026
@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
@DorraJaouad DorraJaouad requested a review from a team as a code owner April 23, 2026 09:41
@DorraJaouad DorraJaouad requested review from CarlSchwan and removed request for a team April 23, 2026 09:41
This was referenced Jun 5, 2026
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux susnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
This reverts commit 60e5a5e.
That commit was only required due to "executionContext" which has
since been removed. See: nextcloud#16310

Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
@susnux susnux force-pushed the revert-pr-12573 branch from a2aea16 to 8325e69 Compare June 9, 2026 15:49

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, otherwise looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress community pull requests from community stale Ticket or PR with no recent activity technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants