fix: unnecessary 404 return request during work package search#1061
Open
nabim777 wants to merge 1 commit into
Open
fix: unnecessary 404 return request during work package search#1061nabim777 wants to merge 1 commit into
nabim777 wants to merge 1 commit into
Conversation
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
fix/404-error-on-wp-search
branch
from
d0f2a4b to
e7213c1
Compare
PHP Code CoverageCoverage after merging fix/404-error-on-wp-search into release/3.1 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
nabim777
requested review from
Kharonus,
NobodysNightmare,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
lindenthal,
psatyal,
saw-jan and
wielinde
as code owners
nabim777
changed the title
nabim777
changed the title
saw-jan
changed the title
Collaborator
Author
|
waiting for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
NcAvatarcomponent was trying to look up Nextcloud user information for OpenProject assignee names. This caused many failed requests to the following:GET /ocs/v2.php/apps/user_status/api/v1/statuses/{assignee}These requests failed because OpenProject names are not Nextcloud users.
So, this PR removes the
userprop which is not necessary in theNcAvatarcomponent.ref: https://nextcloud-vue-components.netlify.app/#/Components/NcAvatar
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfileBackport needed on
release/2.11release/3.1