Skip to content

ci: on test update the error message #1051

Merged
nabim777 merged 2 commits into
masterfrom
tests/fix-user-clean-up
Jun 17, 2026
Merged

ci: on test update the error message #1051
nabim777 merged 2 commits into
masterfrom
tests/fix-user-clean-up

Conversation

@nabim777

@nabim777 nabim777 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Description

There is a flaky CI failure during user cleanup in the API tests. The current error messages do not provide enough information to help with debugging.

The failure did not occur while working on this PR, so the root cause could not be identified. This PR adds error messages to make it easier to identify the issue when the flaky failure happens again.

Related Issue or Workpackage

  Scenario: get information of a non-existing file                                 # /home/runner/work/integration_openproject/integration_openproject/integration_openproject/tests/acceptance/features/api/getFileinfoByFileIDAPI.feature:220
    Given user "Carol" has been created                                            # FeatureContext::userHasBeenCreated()
      HTTP status code 400 is not the expected value 200
      Failed asserting thamatches wereaexpected, notpected 200.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@nabim777 nabim777 self-assigned this Jun 11, 2026
@nabim777 nabim777 changed the title ci: check for failure ci: check for flaky failure Jun 11, 2026
@nabim777 nabim777 force-pushed the tests/fix-user-clean-up branch from 0d585f6 to 66ec50d Compare June 11, 2026 06:10
@nabim777 nabim777 changed the title ci: check for flaky failure ci: on test update the error message Jun 11, 2026
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 force-pushed the tests/fix-user-clean-up branch 3 times, most recently from ba235eb to 06dfa22 Compare June 17, 2026 08:41
@nabim777 nabim777 marked this pull request as ready for review June 17, 2026 08:56
@nabim777 nabim777 force-pushed the tests/fix-user-clean-up branch from 06dfa22 to 9916d5a Compare June 17, 2026 09:02
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 force-pushed the tests/fix-user-clean-up branch from 9916d5a to f738489 Compare June 17, 2026 09:25
@github-actions

Copy link
Copy Markdown

JS Code Coverage

Coverage after merging tests/fix-user-clean-up into master will be
92.49%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js85.92%33.33%50%87.59%12–20, 23–32
src/api
   endpoints.js100%100%100%100%
   settings.js64.71%100%0%73.33%10–11, 14–15
src/components
   AdminSettings.vue96.06%94.74%97.10%96.19%1003–1005, 1025–1028, 568, 568–569, 569, 606–612, 715–716, 720–721, 724–725, 729–730, 740–745, 788–790, 802–805, 818–820, 842–844, 927–929, 964–967
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue91.85%75%100%93.28%64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormAuthMethod.vue98.12%96.88%100%98.12%222–224, 247–250
   FormHeading.vue100%100%100%100%
   FormOpenProjectHost.vue98.87%94.74%100%99.34%167–169, 279
   FormSSOSettings.vue98.57%97.18%96.55%98.91%231–233, 242–243, 358–359
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue96.91%85.71%100%97.67%51–53
src/components/tab
   EmptyContent.vue97.98%90.91%100%98.82%102–103, 107–108
   SearchInput.vue95.31%92.96%94.74%95.78%138–139, 192, 203–208, 267–269, 285–287, 291–296
   WorkPackage.vue86.22%72.50%93.33%87.62%107–116, 129–131, 142–146, 156–158, 176–182, 220, 220–225, 225, 225–236, 81–82
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
   workpackageHelper.js93.80%93.10%88.89%94.24%100–102, 23–27, 54, 54–56, 97–99
src/views
   CreateWorkPackageModal.vue94.18%86.32%90.48%95.43%367–372, 375, 391, 508–511, 516–521, 526–531, 537–540, 543, 559, 559, 600–604, 614–616, 639–640, 648–650, 679–681, 703–705, 714–718
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.95%94.34%93.75%95.10%104–107, 143, 154–155, 189–199, 248–250

@nabim777 nabim777 merged commit 6cdcdaf into master Jun 17, 2026
16 of 18 checks passed
@nabim777 nabim777 deleted the tests/fix-user-clean-up branch June 17, 2026 10:30
nabim777 added a commit that referenced this pull request Jun 18, 2026
* ci: check for failure



* ci: add error log



---------

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777 added a commit that referenced this pull request Jun 18, 2026
* ci: check for failure

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>

* ci: add error log

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>

---------

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777 added a commit that referenced this pull request Jun 18, 2026
* ci: check for failure



* ci: add error log



---------

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants