chore(DevContainer): Add Python 3.13 to devcontainer and remove composer call#14875
Merged
Conversation
4 tasks
…ser call Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
fix/fix-devcontainer
branch
from
ffd047a to
b9bb07c
Compare
miaulalala
approved these changes
May 18, 2026
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Mon, 18 May 2026 16:04:35 GMT |
skjnldsv
approved these changes
May 19, 2026
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Nice, thank you! It was in my TODO, but lacked time/priority :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The devcontainer doesn't work anymore since #14653. The reason is being described in my comment there.
To fix that, I've manually added the appropriate devcontainer feature to install Python 3.13 and removed the
composercall in thepostCreateCommand, as all PHP dependencies doesn't seem to be used anymore (? - Please correct me if I'm wrong!). That way, theDockerfileisn't touched by myself - which is quite important, as it's being used by the CI pipeline.