Extend TPB WLS absorption range#275
Merged
Merged
Conversation
kvjmistry
approved these changes
Apr 23, 2026
Collaborator
kvjmistry
left a comment
kvjmistry
left a comment
There was a problem hiding this comment.
This is an important fix to the simulation. Good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TPB has an absorption spectrum up to ~430 nm which overlaps with the emission spectrum (Fig 11 in this paper). The current implementation only adds the absorption data up to ~380 nm and sets a virtually infinite absorption length for longer wavelengths. This was done intentionally to avoid secondary absorptions and reemissions. We know this is not correct and does not match the data both from the detector and other dedicated setups. As a result, the data-mc agreement in the NEXT-100 detector is good!