Fix: autocomplete popup mispositioned when textarea is scrolled (scro…#74
Open
tricksterzero wants to merge 1 commit into
Open
Fix: autocomplete popup mispositioned when textarea is scrolled (scro…#74tricksterzero wants to merge 1 commit into
tricksterzero wants to merge 1 commit into
Conversation
…ll offset sign) ## Summary The autocomplete suggestion list appears pinned to the bottom of the viewport instead of near the caret when the prompt textarea has been scrolled down. ## Root cause In `#getCaretCoordinates()` (web/js/autocomplete.js), the viewport conversion *adds* the element's scroll offset instead of *subtracting* it. `span.offsetTop` / `offsetLeft` are offsets in the element's content coordinate space. Converting them to viewport coordinates requires subtracting `element.scrollTop` / `scrollLeft`, but the current code adds them. As the textarea is scrolled down, the computed caret Y grows, so `#updatePosition()`'s vertical-collision logic falls back and places the list near the bottom of the screen. ## Fix Before: coordinates.top = rect.top + element.scrollTop + coordinates.top; coordinates.left = rect.left + element.scrollLeft + coordinates.left; After: coordinates.top = rect.top - element.scrollTop + coordinates.top; coordinates.left = rect.left - element.scrollLeft + coordinates.left; This matches the reference implementation (component/textarea-caret-position), which subtracts the scroll offset. ## Reproduction 1. Scroll a prompt textarea down. 2. Trigger autocomplete. => The list appears at the bottom of the screen. With an unscrolled textarea it is positioned correctly. ## Verification After the change, the popup tracks the caret regardless of scroll position. Tested on Windows. Frontend-version-independent: reproduced on both the latest and an older comfyui-frontend-package, so this is unrelated to newtextdoc1111#73.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The autocomplete suggestion list appears pinned to the bottom of the viewport instead of near the caret when the prompt textarea has been scrolled down.
Root cause
In
#getCaretCoordinates()(web/js/autocomplete.js), the viewport conversion adds the element's scroll offset instead of subtracting it.span.offsetTop/offsetLeftare offsets in the element's content coordinate space. Converting them to viewport coordinates requires subtractingelement.scrollTop/scrollLeft, but the current code adds them. As the textarea is scrolled down, the computed caret Y grows, so#updatePosition()'s vertical-collision logic falls back and places the list near the bottom of the screen.Fix
Before:
After:
This matches the reference implementation (component/textarea-caret-position), which subtracts the scroll offset.
Reproduction
Verification
After the change, the popup tracks the caret regardless of scroll position. Tested on Windows. Frontend-version-independent: reproduced on both the latest and an older comfyui-frontend-package, so this is unrelated to #73.