chore: Updated README.md#310
Closed
Sashwatdas123 wants to merge 2 commits into
Closed
Conversation
aavinash-nr
self-requested a review
April 15, 2025 09:18
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
=======================================
Coverage 75.81% 75.81%
=======================================
Files 18 18
Lines 1596 1596
=======================================
Hits 1210 1210
Misses 386 386 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aavinash-nr
previously approved these changes
Apr 15, 2025
Contributor
There was a problem hiding this comment.
Thank you @Sashwatdas123 👏 for the PR , I have checked that this PR adds option --enable-license-key-secret to readme for integration install. which is already present in the newrelic-lambda-extension.
chore: added to integrations update chore: fixed blankspace
Sashwatdas123
force-pushed
the
NR-404207
branch
from
April 15, 2025 11:35
6f9c64d to
b84403f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: NR-404207
What is the issue?
The documentation for the newrelic-lambda-extension refers to the
--enable-license-key-secretoption, yet this option was not covered in this repository's README.Adding it in README because it would be beneficial to document this feature since it is available for both
installandupdatecommands.Issues
This PR resolves #238