feat: Add OCINATGATEWAY entity definition (staging)#3067
feat: Add OCINATGATEWAY entity definition (staging)#3067aprasad-sketch wants to merge 4 commits into
Conversation
Add OCI NAT Gateway entity definition with: - Entity definition with synthesis rules - Golden metrics - Summary metrics - Test data - Using .stg.yml/.stg.json suffix (staging only) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- Error VALIDATING domainType: 'INFRA-OCINATGATEWAY' on Golden metrics for key 'SELECT sum(oci.nat.gateway.bytes.from.natgw) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
- Error VALIDATING domainType: 'INFRA-OCINATGATEWAY' on Golden metrics for key 'SELECT sum(oci.nat.gateway.bytes.from.natgw) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 34, unexpected 'sum(oci.nat.gateway.bytes.from'
- Error VALIDATING domainType: 'INFRA-OCINATGATEWAY' on Golden metrics for key 'sum(oci.nat.gateway.bytes.from.natgw)' - Exception: The NRQL validator was not able to parse the selection.
- We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the
ARB:pendinglabel. Reach#api-review-boardin case of doubts.
|
Hi @aprasad-sketch, could you please review the Entity Bot validation errors? thanks! |
The NR metric names contain 'from'/'to' as dotted segments (e.g. oci.nat.gateway.bytes.from.natgw), which are reserved NRQL keywords and fail golden-metric query validation when unquoted. Backtick the metric names in each select, matching the dotted-lowercase precedent set by infra-gcprouternatgateway. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Dismissing reviews
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
4 participants
Add OCI NAT Gateway entity definition with synthesis rules, golden metrics, and summary metrics. Staging only (
.stg.yml/Metric.stg.json).Entity Type
INFRA-OCINATGATEWAYoci_nat_gatewayocid1.natgatewayGolden Metrics
oci.nat.gateway.bytes.from.natgw)oci.nat.gateway.bytes.to.natgw)oci.nat.gateway.connections.established)oci.nat.gateway.drops.to.natgw)Metric Source
https://docs.oracle.com/en-us/iaas/Content/Network/Reference/nat-gateway-metrics.htm