fix(gui): always process text input from char events#587
Open
ypsvlq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms (e.g. my Wayland setup with IBus),
.button_pressevents are not sent for character keys when text input is enabled.Unfortunately fixing this exposes an issue in wio where
.charevents were incorrectly sent whilst ctrl/alt were held on Wayland, so currently it will double register there. This was fixed in ypsvlq/wio@dcdd790 which can be applied to your fork by gating https://github.com/neurocyte/wio/blob/6d7a5919de5f2e284ace3be28ea3a592645b69ea/src/unix/wayland.zig#L775-L786 inif (!modifiers.control and !modifiers.alt).