Conv3d, new configurator#6
Open
AnihilatorGun wants to merge 40 commits into
Open
Conversation
… from Conv3dWgrad
| return ratio | ||
|
|
||
|
|
||
| def _build_toml( |
Member
There was a problem hiding this comment.
Nothing serious, but it might be worth finding some lib that allows building toml from e.g. dict. The upside of the current approach is that you avoid adding some dumb dependency like "toml writer" or smth like that.
|
|
||
|
|
||
| class EmptyKwarg: | ||
| class ConfArg: |
Member
There was a problem hiding this comment.
You can add type annotation here. For example ConfArg[T]. In this case, def fn(x: int) would become def fn(x: ConfArg[int])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.