Updated SelectedAxis to only contain coordinate fields that are associated with the sliced axis. This resolves an unnecessary conflict when a coordinate slice is combined with another coordinate that has a field with the name corresponding to other coordinate types. To ensure that multidimensional coordinate fields are not lost due to the order of appearance, CartesiaProduct canonicalize sorted components in fields property.#69
Merged
Conversation
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_875397372
branch
2 times, most recently
from
7bdf970 to
4ec6385
Compare
…iated with the sliced axis. This resolves an unnecessary conflict when a coordinate slice is combined with another coordinate that has a field with the name corresponding to other coordinate types. To ensure that multidimensional coordinate fields are not lost due to the order of appearance, CartesiaProduct canonicalize sorted components in fields property. PiperOrigin-RevId: 875724189
copybara-service
Bot
force-pushed
the
test_875397372
branch
from
4ec6385 to
0832141
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated SelectedAxis to only contain coordinate fields that are associated with the sliced axis. This resolves an unnecessary conflict when a coordinate slice is combined with another coordinate that has a field with the name corresponding to other coordinate types. To ensure that multidimensional coordinate fields are not lost due to the order of appearance, CartesiaProduct canonicalize sorted components in fields property.