feat(catalog): add tokei and scc catalog entries#30
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds new tool definitions for scc and tokei to the CLI tools catalog and updates the documentation to reflect the increased tool count. Feedback was provided to use the {arch} placeholder in the scc asset pattern to ensure cross-architecture compatibility and to remove the unnecessary rust runtime requirement for tokei to avoid redundant toolchain installations.
Both tools were already recommended in references/preferred-tools.md (as the fast replacement for cloc) and listed in SKILL.md's tool selection table, but had no catalog entry — so the install/audit workflow could not actually install them. This closes that gap by adding: - catalog/tokei.json (cargo + brew) - catalog/scc.json (github_release_binary + go + brew) Also bumps the cataloged-entries count in SKILL.md and README.md from 74 to 77 to match the current catalog/ directory. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
CybotTM
force-pushed
the
feat/catalog-tokei-scc
branch
from
4e92811 to
965439e
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds missing catalog entries for the code-counting tools tokei and scc so the skill’s install/audit workflows can install them, and updates documented catalog counts accordingly.
Changes:
- Add
catalog/tokei.jsonwithcargoandbrewinstall options. - Add
catalog/scc.jsonwithgithub_release_binary(and additional listed methods). - Update
SKILL.mdandREADME.mdcounts from 74 → 77 to match the currentcatalog/size.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| skills/cli-tools/SKILL.md | Updates documented number of cataloged entries to 77. |
| README.md | Updates documented supported-tool counts and directory-structure note to 77+. |
| catalog/tokei.json | New catalog entry for tokei with cargo/brew methods. |
| catalog/scc.json | New catalog entry for scc with GitHub-release binary download metadata and method list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- scc.json: use {arch} placeholder in asset_pattern so the arch_map is
actually applied for non-x86_64 hosts (gemini-code-assist).
- scc.json: drop the "go" install method — the cli-tools-skill
installer (scripts/lib/reconcile.sh) only supports apt, cargo, npm,
gem, pip, pipx, brew, github_release_binary. The "go" entry caused
"Unknown method: go" on stderr (Copilot).
- scc.json & tokei.json: brew config now uses `formula` to match the
reconciler's schema (`jq -r '.formula'`); the prior `package` key was
silently ignored (Copilot).
- tokei.json: drop `requires: ["rust"]` — `check_dependencies` runs
`command -v` on each requires entry, and there is no `rust` binary
(it would be `rustc`/`cargo`). tokei has no runtime dependency on
Rust once installed (gemini-code-assist + Copilot).
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
|
Summary
tokeiandsccwere already recommended throughout the skill (inSKILL.md's tool selection table as the modern replacement forcloc, and with full usage examples inreferences/preferred-tools.md), but they had nocatalog/*.jsonentry — so the install/audit workflow couldn't actually install them.This PR closes that gap:
catalog/tokei.json(install methods:cargo,brew)catalog/scc.json(install methods:github_release_binary,go,brew)SKILL.mdandREADME.mdfrom74to77to match the currentcatalog/directory.Both schemas mirror the existing pattern (
ripgrep.json,fd.json) and are aligned with the canonical entries in thecoding_agent_cli_toolsetinventory.Test plan
jq empty catalog/tokei.json catalog/scc.json— both valid JSONls catalog/*.json | wc -lmatches the new claimed count (77)make install-tokei/make install-sccresolves to a working install (manual verification post-merge)