Skip to content

Apply errata#7

Merged
kwatsen merged 19 commits into
mainfrom
apply-errata
Jun 12, 2026
Merged

Apply errata#7
kwatsen merged 19 commits into
mainfrom
apply-errata

Conversation

@kwatsen

@kwatsen kwatsen commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Issues closed

Closes #6
Closes netmod-wg/yang-next#134

Design

No design. I simply walked over the errata listed for RFC 7950 here. All errata marked Verified and Held for Document Update were applied. Each errata is applied in its own git commit with a link to the errata to simplify reviews.

Additional Information

There are two errata in the Reported state. Email sent to the list here.

@kwatsen
kwatsen requested a review from a team as a code owner June 5, 2026 22:07
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

All of the following MUST be verified by AUTHORS before merging to main:

  • Updated "Changes Since RFC 7950" section, or N/A?
  • Updated "IANA Considerations" section, or N/A?
  • Updated "Security Considerations" section, or N/A?
  • Updated "Normative/Informational References" sections, or N/A?
  • Updated "Acknowledgements" section, or N/A? (Not GitHub users)

The following MUST be verified by the EDITOR before merging to main:

  • The XML artifact uploads to Datatracker?

@kwatsen

kwatsen commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Should we add each errata-submitter's name to the Acknowledgements section?

reshad-equinix
reshad-equinix previously approved these changes Jun 8, 2026

@reshad-equinix reshad-equinix left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Another pair of eyes would be good though.

@reshad-equinix

Copy link
Copy Markdown

Should we add each errata-submitter's name to the Acknowledgements section?

IMO yes.

@rgwilton rgwilton left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked errata 7.

Comment thread draft-yn-netmod-yang2.xml Outdated
Comment thread draft-yn-netmod-yang2.xml Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies verified and “Held for Document Update” RFC 7950 errata to the draft-yn-netmod-yang2.xml Internet-Draft source, aligning examples, YANG/XPath text, and ABNF grammar with the corrected specification text.

Changes:

  • Updates multiple YANG and XML examples (imports/prefixes, decimal64 XPath comparison example, notification XML example namespace, bits example semicolon, etc.).
  • Fixes and clarifies specification text in several sections (augment substatements, deviation “delete” wording, require-instance applicability, derived-from-or-self() description, when context rules).
  • Extends leafref path ABNF to include deref()-based expressions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread draft-yn-netmod-yang2.xml Outdated
Comment thread draft-yn-netmod-yang2.xml Outdated
Comment thread draft-yn-netmod-yang2.xml
…his means that the applied text is NOT 1-1 with the errata's suggested solution.
reshad-equinix
reshad-equinix previously approved these changes Jun 8, 2026
@kwatsen

kwatsen commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Regarding this question:

Should we add each errata-submitter's name to the Acknowledgements section?

Reshad said yes, and Lou thinks that it's a good idea also. But I don't want to do it in this PR, because the other PR make-baseline restructures that section. So the plan is to merge this branch into main, then merge main into the make-baseline branch, where the Acknowledgements section will be updated.

@kwatsen

kwatsen commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Thank you Reshad and Rob for your comments. All conversations have been resolved.

I will merge this PR now.

@kwatsen
kwatsen merged commit bee73a7 into main Jun 12, 2026
9 of 10 checks passed
@kwatsen
kwatsen deleted the apply-errata branch June 12, 2026 22:41
@reshad-equinix reshad-equinix mentioned this pull request Jun 30, 2026
kwatsen added a commit that referenced this pull request Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply Errata from RFC 7950 Apply verified errata and resolve held for document update errata

4 participants