feat: allow passing extra headers to Lighthouse#182
Draft
erezrokah wants to merge 1 commit into
Draft
Conversation
erezrokah
force-pushed
the
feat/custom_headers
branch
from
cdf617a to
e01f906
Compare
|
Hi, this is a pretty old PR, but we would love to use headers for basic auth purposes in our project. What can we help with to move this along? TIA! |
|
Is it possible to finalize this pr so we can add headers to lighthouse because we want to use basic auth instead of netlify password protection. But we cant add headers to the plugin lighthouse requests. |
|
@erezrokah @dsegovia90 Hi would it be possible to implement this feature of adding additional headers for Basic Auth or something else ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion on the issue https://github.com/netlify-labs/netlify-plugin-lighthouse/issues/152
Opening as draft so I can get some feedback on use case.