Skip to content

test(axis): full coverage for under-tested skill rules across all domains (AX-107)#85

Merged
seancdavis merged 5 commits into
mainfrom
seandavis/ax-107-add-axis-scenarios-for-under-tested-skill-rules-audit-d
Jul 7, 2026
Merged

test(axis): full coverage for under-tested skill rules across all domains (AX-107)#85
seancdavis merged 5 commits into
mainfrom
seandavis/ax-107-add-axis-scenarios-for-under-tested-skill-rules-audit-d

Conversation

@seancdavis

@seancdavis seancdavis commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Full coverage pass (AX-107) — adds a scenario for every under-tested skill rule the audit's §D surfaced (rules already documented in the skills but previously untested). Scenarios-only; each check is grounded in existing skill text so the with-skill variant scores goal ≥95. (Supersedes the initial four-scenario tranche.)

What changed

  • 57 new scenarios across all 14 domains covering taught-but-untested rules — e.g. already-applied migrations are immutable (roll forward), functions custom-path disables the default route / 60 s sync ceiling / cron-is-UTC, MCP GET→405 (SSE trap) + 406 Accept-header diagnosis, deploy failed-deploy≠downtime + netlify logs source flags, identity role-change-needs-token-refresh + server-side role gating, caching same-URL-identical-Netlify-Vary + context-scoped invalidation, edge --geo mock + onError redirect form, agent-runner --model / error terminal state / link-prereq, and more.
  • One coupled netlify-deploy/SKILL.md edit — the roll-back guidance backing the deploy-failure-not-downtime scenario — is the single non-scenario change (QA-noted as not harmful).

Closes AX-107.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seancdavis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1c404d94-fefe-448a-b935-a599510cdd68

📥 Commits

Reviewing files that changed from the base of the PR and between fce2a2f and 485e448.

⛔ Files ignored due to path filters (2)
  • codex/skills/netlify-deploy/SKILL.md is excluded by !codex/**
  • cursor/rules/netlify-deploy.mdc is excluded by !cursor/**
📒 Files selected for processing (58)
  • axis-scenarios/agent-runner/error-terminal-state.ts
  • axis-scenarios/agent-runner/link-prerequisite.ts
  • axis-scenarios/agent-runner/model-selection.ts
  • axis-scenarios/agent-runner/permission-request-content.ts
  • axis-scenarios/ai-gateway/limits-context-batch-headers.ts
  • axis-scenarios/ai-gateway/local-dev-positive-path.ts
  • axis-scenarios/ai-gateway/model-alias-nuances.ts
  • axis-scenarios/ai-gateway/universal-gateway-vars.ts
  • axis-scenarios/ai-gateway/untracked-usage-diagnosis.ts
  • axis-scenarios/blobs/size-and-key-limits.ts
  • axis-scenarios/caching/deploy-invalidation-context-scope.ts
  • axis-scenarios/caching/purge-entire-site.ts
  • axis-scenarios/caching/static-assets-auto-cache.ts
  • axis-scenarios/caching/vary-consistent-per-url.ts
  • axis-scenarios/config/dev-context-vs-dev-block.ts
  • axis-scenarios/config/language-conditions.ts
  • axis-scenarios/config/redirect-status-codes.ts
  • axis-scenarios/config/toml-placement.ts
  • axis-scenarios/database/db-ambiguous-production-request.ts
  • axis-scenarios/database/db-applied-migration-immutable.ts
  • axis-scenarios/database/db-environment-not-configured.ts
  • axis-scenarios/database/db-native-driver-transaction.ts
  • axis-scenarios/database/db-preflight-questions.ts
  • axis-scenarios/deploy/deploy-failure-not-downtime.ts
  • axis-scenarios/deploy/env-var-branch-context.ts
  • axis-scenarios/deploy/env-var-import-export.ts
  • axis-scenarios/deploy/logs-default-scope.ts
  • axis-scenarios/edge-functions/context-ip.ts
  • axis-scenarios/edge-functions/geo-mock-local-dev.ts
  • axis-scenarios/edge-functions/npm-package-import.ts
  • axis-scenarios/edge-functions/on-error-page.ts
  • axis-scenarios/edge-functions/response-header-timeout.ts
  • axis-scenarios/forms/list-spam-delete-api.ts
  • axis-scenarios/forms/submission-timeout-limits.ts
  • axis-scenarios/forms/vanilla-ajax-form.ts
  • axis-scenarios/frameworks/astro-hybrid-removal.ts
  • axis-scenarios/frameworks/nuxt-env-prefix.ts
  • axis-scenarios/frameworks/static-custom-404.ts
  • axis-scenarios/frameworks/tanstack-version-floor.ts
  • axis-scenarios/functions/functions-cron-utc.ts
  • axis-scenarios/functions/functions-custom-path-disables-default.ts
  • axis-scenarios/functions/functions-js-beats-ts.ts
  • axis-scenarios/functions/functions-scheduled-timeout.ts
  • axis-scenarios/functions/functions-single-region.ts
  • axis-scenarios/functions/functions-sync-timeout-background.ts
  • axis-scenarios/identity/hydrate-session.ts
  • axis-scenarios/identity/oauth-only-omit-form.ts
  • axis-scenarios/identity/server-side-login-redirect.ts
  • axis-scenarios/identity/signup-email-verified-branching.ts
  • axis-scenarios/identity/surface-and-stop-on-failure.ts
  • axis-scenarios/image-cdn/source-image-cache-headers.ts
  • axis-scenarios/image-cdn/upload-size-validation.ts
  • axis-scenarios/mcp-servers/accept-header-406.ts
  • axis-scenarios/mcp-servers/api-key-scoping-restraint.ts
  • axis-scenarios/mcp-servers/get-returns-405.ts
  • axis-scenarios/mcp-servers/image-content-return-limit.ts
  • axis-scenarios/mcp-servers/oauth-public-connector.ts
  • skills/netlify-deploy/SKILL.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch seandavis/ax-107-add-axis-scenarios-for-under-tested-skill-rules-audit-d

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seancdavis

Copy link
Copy Markdown
Collaborator Author

Codex review: I audited this against AX-107 and the branch diff. I did not find blocking issues. Generated Codex/Cursor mirrors are in sync, and skill-validator check --strict skills/ passes with network access. Minor scope note: this is not strictly scenario-only because it also updates skills/netlify-deploy/SKILL.md, but the edit supports the new deploy scenario and is not harmful. I did not run AXIS tests per request.

@seancdavis seancdavis changed the title test(axis): cover four taught-but-untested cross-cutting platform rules test(axis): full coverage for under-tested skill rules across all domains (AX-107) Jul 7, 2026
@seancdavis

Copy link
Copy Markdown
Collaborator Author

Codex review update: I re-audited the new PR head (485e448). I did not find blocking issues. Generated Codex/Cursor mirrors are in sync, and skill-validator check --strict skills/ passes with network access. I did not run AXIS tests per request.

@seancdavis seancdavis marked this pull request as ready for review July 7, 2026 20:14
@seancdavis seancdavis merged commit ff8ae82 into main Jul 7, 2026
6 checks passed
@seancdavis seancdavis deleted the seandavis/ax-107-add-axis-scenarios-for-under-tested-skill-rules-audit-d branch July 7, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant