Skip to content

fix: pin DENO_VERSION_RANGE to not use 2.9.0 which introduced compatibility issue with our bootstrap #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pieh wants to merge 2 commits into from
+2 −2
Closed

fix: pin DENO_VERSION_RANGE to not use 2.9.0 which introduced compatibility issue with our bootstrap #7113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0ffd0
fix: pin DENO_VERSION_RANGE to not use 2.9.0 which introduced compati…
pieh Jun 26, 2026
ec7b6d9
test: use upper bound version of deno for tests
pieh Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
node-version: ['24']
# Maximum supported deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
# If there is no upper band - this should be set to whatever is the latest deno version at the time of updating this workflow.
deno-version: ['v2.8.0']
deno-version: ['v2.8.2']
# We test on the oldest supported Node.js + Deno versions, but only on Linux
include:
- os: ubuntu-24.04
Expand Down
2 changes: 1 addition & 1 deletion packages/edge-bundler/node/bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const LEGACY_DENO_VERSION_RANGE = '1.39.0 - 2.2.4'
// When updating DENO_VERSION_RANGE, ensure that the deno version
// on the netlify/buildbot build image satisfies this range!
// https://github.com/netlify/buildbot/blob/f9c03c9dcb091d6570e9d0778381560d469e78ad/build-image/noble/Dockerfile#L410
export const DENO_VERSION_RANGE = '^2.4.2'
export const DENO_VERSION_RANGE = '2.4.2 - 2.8.2'

@coderabbitai coderabbitai Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift

Upper-bounding the range now makes auto-download fall back to 2.4.2, not 2.8.2.

packages/edge-bundler/node/downloader.ts:92-109 returns semver.minVersion(range) whenever release-latest is outside the range. With 2.4.2 - 2.8.2, the first upstream release above 2.8.2 causes the bridge to download 2.4.2, so this change does not actually keep the runtime on the latest safe version. Please update the resolver to fall back to the range’s upper bound (or an explicit pinned version) instead of the minimum.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/edge-bundler/node/bridge.ts` at line 22, The DENO_VERSION_RANGE
change in bridge.ts causes the downloader fallback in downloader.ts to pick the
range minimum instead of the intended latest safe version. Update the version
resolution logic in the downloader path that uses semver.minVersion(range) so
that when release-latest is outside the allowed range it falls back to the upper
bound of DENO_VERSION_RANGE, or to an explicitly pinned version, rather than the
minimum. Use the DENO_VERSION_RANGE constant and the resolver in downloader.ts
to keep the auto-download target on the newest approved release.


export type OnBeforeDownloadHook = () => void | Promise<void>
export type OnAfterDownloadHook = (error?: Error) => void | Promise<void>
Expand Down
Loading