perf: optimize Playwright test speed by removing waitForTimeout#80
Merged
Conversation
lewis617
commented
Jun 30, 2026
lewis617
commented
Contributor
- Serve codicons locally from node_modules instead of CDN
- Add waitForFileSuggestionRequest() helper for condition-based waits
- Add getMessageCount() helper for tracking message state
- Replace 61 waitForTimeout calls (~18s) with event-driven waits
- Use expect().toPass() for scroll and render verification
- Reduce test suite time from 60s to 50s (17% improvement)
- Serve codicons locally from node_modules instead of CDN - Add waitForFileSuggestionRequest() helper for condition-based waits - Add getMessageCount() helper for tracking message state - Replace 61 waitForTimeout calls (~18s) with event-driven waits - Use expect().toPass() for scroll and render verification - Reduce test suite time from 60s to 50s (17% improvement)
lewis617
force-pushed
the
perf/optimize-playwright-test-speed
branch
from
e0ca39e to
c720e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.