feat: convert /model dialog from text inputs to dropdown selects#77
Merged
Conversation
- Replace text input fields with <select> dropdowns in ModelDialog - Get configured models list from agent.getConfiguredModels() (like wave-agent) - Get current model values from agent.getModelConfig() for correct selection - Add getConfiguredModels message handler in messageHandler.ts - Add configuredModels and currentModel/currentFastModel to ChatState - Update existing tests and add new modelDropdown.test.ts (4 tests) - All 228 Playwright tests pass
lewis617
force-pushed
the
feat/model-dropdown-select
branch
from
5c4be7d to
8e8e483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert the
/modeldialog from manual text input fields to dropdown selects populated with available models from the SDK, matching wave-agent's behavior.Changes
Backend (
src/session/messageHandler.ts)getConfiguredModelsmessage handleragent.getConfiguredModels()(SDK's ConfigurationService with remote models)agent.getModelConfig()for correct dropdown selectionFrontend
ModelDialog.tsx: Replace<input type="text">with<select>dropdownsChatApp.tsx: HandleconfiguredModelsResponse, addSET_CONFIGURED_MODELSandSET_CURRENT_MODELSactionstypes/index.ts: AddconfiguredModels,currentModel,currentFastModelto ChatStateTests
e2e/webview/modelDropdown.test.ts(4 tests for dropdown behavior)model-status-login-commands.test.tsandmodel-dialog.demo.tsfor new select elementsTest Results