fix: execute Stop hooks before processing pending notifications#1344
Open
lewis617 wants to merge 2 commits into
Open
fix: execute Stop hooks before processing pending notifications#1344lewis617 wants to merge 2 commits into
lewis617 wants to merge 2 commits into
Conversation
Align with Claude Code which fires Stop hooks unconditionally when AI finishes responding. Previously, pending background task notifications would skip Stop hooks, causing settings.json Stop hooks (e.g. send_assistant_message.sh) to not execute. Move the notificationQueue check to after Stop hooks execution so that hooks always fire, and notifications are processed in the next loop iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a background task notification is pending at the time the AI finishes responding, Wave would skip Stop hooks and directly restart the loop to process the notification. This caused
~/.wave/settings.jsonStop hooks (e.g.send_assistant_message.sh) to not execute.Root Cause
In
aiManager.ts, thefinallyblock checkednotificationQueue.hasPending()before executing Stop hooks. If notifications were pending, Stop hooks were skipped entirely.Fix
Align with Claude Code, which fires Stop hooks unconditionally when the AI finishes responding (no queue checks in the
!needsFollowUppath). Move the notificationQueue check to after Stop hooks execution, so:Test