fix(vsce): push restored messages to webview after session restore#1338
Merged
Conversation
ChatSession.restoreSession() called agent.restoreSession() which stored restored messages via onMessagesChange callback, but never called throttledUpdateChatMessages() to push them to the webview. This caused the session selector to switch sessions without loading the conversation history. Add the missing throttledUpdateChatMessages(this.messages) call after agent.restoreSession(), mirroring the pattern used in clearChat().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When selecting a session in the VS Code extension session selector, the conversation history (messages) was not loaded. The session dropdown would switch to the selected session, but the message list remained empty or showed the previous session's messages.
Root Cause
called which internally triggered the SDK's callback. However, in the VSCE layer, the callback only stored the messages into — it did not call to push the updated message list to the webview.
This is in contrast to , which explicitly calls after .
Fix
Add after in . The flag (already set before the call) ensures the update fires immediately rather than being throttled.
Testing